Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Improved (but hacky) context menu loading #11966

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Feature: Improved (but hacky) context menu loading #11966

merged 3 commits into from
Apr 4, 2023

Conversation

hishitetsu
Copy link
Member

In this PR, a dummy context menu is generated when the application is launched.
I know this is hacky, but this certainly improves the performance of the first appearance of the context menu.

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@yaira2 yaira2 changed the title Feature: More improved (but hacky) context menu loading Feature: Improved (but hacky) context menu loading Apr 4, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 4, 2023

This works really well for folders, is there anything we can do for files as well?

yaira2
yaira2 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 4, 2023
@yaira2 yaira2 merged commit f616232 into files-community:main Apr 4, 2023
@hishitetsu
Copy link
Member Author

This works really well for folders, is there anything we can do for files as well?

It seems work well for files as well to me.

@yaira2
Copy link
Member

yaira2 commented Apr 5, 2023

It's on and off, very likely depends on what else is opened at the time.

@hishitetsu hishitetsu deleted the WarmUpContextMenu branch April 5, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hishitetsu @yaira2